Skip to content

Fix rspec and rubocop issues - #42

Open
NotFounds wants to merge 1 commit into
kigster:mainfrom
NotFounds:fix-ci-rspec-and-rubocop
Open

NotFounds wants to merge 1 commit into
kigster:mainfrom
NotFounds:fix-ci-rspec-and-rubocop

Conversation

@NotFounds

@NotFounds NotFounds commented Sep 18, 2026 •

Copy link
Copy Markdown

When I created a pull request for #41, the CI failed in an unrelated section.

Since rspec-its and rubocop were configured to use the latest versions in the CI environment, I fixed the code to keep up with those changes.

P.S. I'm not sure about the Mermaid error. Sorry.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are small, localized, and appear to be straightforward compatibility/style fixes without altering runtime behavior in a risky way.

Pull request overview

This PR updates the codebase to stay compatible with newer CI toolchain behavior (notably rspec-its) and resolves minor RuboCop/style issues that were causing CI failures unrelated to the functional changes in PR #41.

Changes:

  • Update the Key spec to avoid its(:...) calls on private methods by asserting via send.
  • Minor whitespace cleanup in the Redis provider.
  • Small Ruby style modernizations (safe navigation, removing unnecessary explicit receivers).
File summaries
File Description
spec/simplefeed/providers/serialization/key_spec.rb Updates specs to call private methods explicitly, improving compatibility with newer rspec-its behavior.
lib/simplefeed/providers/redis/provider.rb Removes a stray blank line/whitespace in paginate.
lib/simplefeed/providers/redis/driver.rb Simplifies block invocation in debug output using safe navigation.
lib/simplefeed/event.rb Removes redundant self. receivers and keeps behavior the same.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch was successfully deployed

1 active deployment
Code Coverage — 7d40b588 Deployed Sep 18, 2026 by NotFounds via test #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants