CHECK-395: Hook new project page fetch into ProjectPageViewModel - #2952
Open
amy-at-kickstarter wants to merge 3 commits into
Open
CHECK-395: Hook new project page fetch into ProjectPageViewModel#2952amy-at-kickstarter wants to merge 3 commits into
amy-at-kickstarter wants to merge 3 commits into
Conversation
Collaborator
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
| AppEnvironment.popEnvironment() | ||
| } | ||
|
|
||
| static func mockNetworkRequests_newQuery( |
Contributor
Author
There was a problem hiding this comment.
When we conclude the experiment, it will be easy to replace the old mocking helper for the old query with this new mocking helper.
amy-at-kickstarter
marked this pull request as ready for review
August 6, 2026 13:45
amy-at-kickstarter
requested review from
a team,
scottkicks and
stevestreza-ksr
and removed request for
a team
August 6, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Use
ProjectPageFetcher.fastFastProjectPageinProjectPageViewModelwhen theInstantPledgeButtonExperimentis on.🤔 Why
This actually integrates the faster fetch with
ProjectPageViewModel.👀 See
Not all pages have this dramatic of a speedup, but here's one that makes a particular satisfying before-and-after gif.