Skip to content

Add new displayMenu options - #1117

Draft
Qing8 wants to merge 4 commits into
kiali:masterfrom
Qing8:configurable-graph-badge-defaults
Draft

Qing8 wants to merge 4 commits into
kiali:masterfrom
Qing8:configurable-graph-badge-defaults

Conversation

@Qing8

@Qing8 Qing8 commented Nov 6, 2026

Copy link
Copy Markdown

Verification Step

  • Tested on an EKS cluster running Kubernetes 1.36. Used the v2.34.0 Operator runtime.
    Confirmed that spec.kiali_feature_flags.ui_defaults.graph.display_menu propagates into the generated Kiali ConfigMap, preserving explicit false values. Also verified updating the overrides and removing them.

@Qing8 Qing8 changed the title Add new options Add new displayMenu options Nov 6, 2026
Comment on lines +555 to +556
# Support all options under the Display menu.
# For example, display_menu: {virtual_services: false} disables Virtual Services by default.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put comments in here. Comments in this file are generally only for describing default values that diverge from the value you see in the file. We don't describe the settings here - that's the job of the CRD Schema's description.

The values you see in this example CR file are generally to be set to the default values that the operator uses. Since the default value the operator uses for this value (as seen in the roles/default/kiali-deploy/defaults/main.yml file) is {} then display_menu: {} is all you need here without comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants