Repository navigation
Split test server infrastructure: TestServer for HttpClient, Kestrel for PuppeteerSharp - #1
Merged
Conversation
…tion Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
…eanup, and exception handling Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add NetInteractor.PuppeteerSharp project with IWebAccessor implementation
Add PuppeteerSharp-based IWebAccessor implementation
Jan 21, 2026
kerryjiang
marked this pull request as ready for review
January 21, 2026 08:15
… approach Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Add PuppeteerSharp-based IWebAccessor implementation
Add parameterized unit tests for PuppeteerSharpWebAccessor
Jan 21, 2026
Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Add parameterized unit tests for PuppeteerSharpWebAccessor
Enable PuppeteerSharp tests with real HTTP server
Jan 21, 2026
…emove WebAccessorIntegrationTests Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Enable PuppeteerSharp tests with real HTTP server
Replace URL rewriting with config parameters; consolidate test classes
Jan 21, 2026
… enable PuppeteerSharp via env var Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Replace URL rewriting with config parameters; consolidate test classes
Pass web accessor instances and baseUrl as direct test parameters
Jan 21, 2026
Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Pass web accessor instances and baseUrl as direct test parameters
Remove unused accessorName parameter from IntegrationTests
Jan 21, 2026
Co-authored-by: kerryjiang <456060+kerryjiang@users.noreply.github.com>
Copilot
AI
changed the title
Remove unused accessorName parameter from IntegrationTests
Split test server infrastructure: TestServer for HttpClient, Kestrel for PuppeteerSharp
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpClient tests were using Kestrel (real HTTP server with port binding) when TestServer (in-memory) is more appropriate. PuppeteerSharp requires real HTTP endpoints that browsers can access.
Changes
TestWebApplicationFactory
ServerModeenum:TestServer(in-memory) vsKestrel(real HTTP)UseTestServer(), returnshttp://localhostplaceholderUseKestrel()with dynamic port, returns actual URL likehttp://127.0.0.1:12345WebAccessorTestData
TestWebApplicationFactory(ServerMode.TestServer)TestWebApplicationFactory(ServerMode.Kestrel)Impact
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.