Fix binary_crossentropy dtypes and slogdet sign on Metal - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns main green again after keras pluggable_backend moved to aca7bf905. It fixes two unrelated things:
binary_crossentropycasts its inputs to a float dtype like torch does (keras#23663). A bool target failed on mlx'snegative.slogdetdivides the real and imaginary parts separately. mlx 0.32.3's Metal complex division gives nan for a tiny divisor, so the sign came out nan on macOS.They're in one PR because each alone leaves the other leg red.