Skip to content

feature/expose-expiration-data - #156

Open
Drealise wants to merge 2 commits into
kee-org:masterfrom
Drealise:feature/expose-expiration-data
Open

Drealise wants to merge 2 commits into
kee-org:masterfrom
Drealise:feature/expose-expiration-data

Conversation

@Drealise

Copy link
Copy Markdown

PR

A small modification to KeePassRPC that includes Expiry ("expires") and Expiration Date ("expiryTime") metadata. This will allow the Kee extension to optionally filter out expired entries by these properties.

Side-note

The supplied test battery has 13 fails out of 116 tests total in the original version (kee-org/keepassrpc:master branch at time of forking):

  • 10 assertion failures: all in URLMatchTest, pre-existing logic/test expectation mismatches
  • 3 NullReferenceExceptions: in URLSummaryTest, likely the public suffix domain cache (publicsuffix.org download) not populating the Domain object correctly

The same outcome in this fork => no apparent regression. Manual tests also show the functionality is as intended with no side-effects.

P.S.

Feel free to check out the KeePassRPC CLI interfacer utility I developed to facilitate development of this feature. Could be useful for other dev stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant