test fail due to silent expectation with new ggplot version

[teunbrand]

Hi there,

We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
We found that the following tests expect silence, but the new version throws warnings via the ggtree package.

DAISIEprep/tests/testthat/test-plot_phylod.R

Lines 1 to 19 in 5389934

	test_that("plot_phylod runs silent without error", {
	phylod <- create_test_phylod(test_scenario = 1)
	expect_silent(plot_phylod(phylod = phylod, node_pies = FALSE))
	})
	test_that("plot_phylod runs silent without error", {
	phylod <- create_test_phylod(test_scenario = 2)
	expect_silent(plot_phylod(phylod = phylod, node_pies = FALSE))
	})
	test_that("plot_phylod runs silent without error", {
	phylod <- create_test_phylod(test_scenario = 1)
	expect_silent(plot_phylod(phylod = phylod, node_pies = TRUE))
	})
	test_that("plot_phylod runs silent without error", {
	phylod <- create_test_phylod(test_scenario = 2)
	expect_silent(plot_phylod(phylod = phylod, node_pies = TRUE))
	})

This isn't a mistake from your side, but I'd like to draw your attention to the matter in case CRAN starts complaining in the future.
You can test your code with the development version of ggplot2 by installing it as follows:

# install.packages("pak")
pak::pak("tidyverse/ggplot2")

We aim to release the new ggplot2 version in about 2 weeks, and we'll reach out to the ggtree package too. If they manage to prevent the warnings from occuring in the first place, all should be well. Hopefully this will inform you in a timely manner.

Best wishes,
Teun

[joshwlambert]

Thank you for raising this @teunbrand! I'll install the newest version of {ggplot2} and look into the warning.