Repository navigation
Record the exit of the verify command that actually ran - #355
Merged
Merged
Conversation
A claimed --verify-exit is not evidence Validation ran, so capture and complete execute --verify-command and refuse a result that disagrees with that run. gate_check stays enter-phase. Co-authored-by: Cursor <cursoragent@cursor.com>
Fold the executed-run test into VerifyReceipt.ran so review still requires a command that actually ran without raising CCN. Co-authored-by: Cursor <cursoragent@cursor.com>
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdlc.sh capture(code phase) andsdlc.sh completeexecute--verify-commandand store the observed exit, pass/fail, andexecuted: true.--verify-exitor--verify-resultthat disagrees with that run is refused, and the lesson is not staged. Review still requires an executed receipt;gate_checkstays enter-phase.Test plan
engine/tests_unit/test_verify_receipt.py,test_workflow_gates.py,test_workflow.pytests/test-verify-receipt.sh(including a claimed pass onfalse)tests/test-gate-review-validation.shtests/test-quality-gates-constraint-honest.shMade with Cursor