Repository navigation
Tighten I2 so random *.spec.md files fail review scope - #274
Merged
Merged
Conversation
Only tests/, test_*.py, *_test.py, and docs/review.spec.md stay allowed; command specs under spec/ or engine/ must not auto-pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_allowed_test_pathno longer treats every*.spec.mdas an allowed I2 test path. Allowed paths aretests/**,engine/tests_{unit,integration,e2e}/**, basenametest_*.py/*_test.py, and the documented exceptiondocs/review.spec.md.spec/commands/lifecycle-code.spec.mdorengine/.../evil.spec.mdnow FAILs I2 review scope.docs/review.spec.mdstill PASSes.origin/main. No Work ID invented. I3 copy-only hooks untouched. Does not merge or extend Lock dogfood slash commands to the shipped Kasana I1/I2 templates. #271 or Make I2 review scope see committed extras and reject a missing --base #272.Test plan
pytest engine/tests_unit/test_canvas.py(15 passed)test_diff_scope_allowed_test_path_passesstill locksdocs/review.spec.mdtest_diff_scope_random_spec_md_is_not_an_allowed_test_pathFAILsspec/commands/lifecycle-code.spec.mdandengine/src/sdlc_engine/evil.spec.mdMade with Cursor