Repository navigation
Optional DIF review when snapshots exist - #209
Merged
Merged
Conversation
Review templates call review --quiet only if before/after snapshots are present. Missing CLI or files is skip. Login fixtures are banned. Orch CI covers detect-and-skip and exit 1 without Maven.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional DIF on
/sdlc-spdd-review, same shape as architect: useful when present, ignored when not.review --quietonly if the sibling CLI andspdd/snapshots/<WORK-ID>-before.json+-after.jsonexist.embabel-diforder-status-*.json).tests/test-optional-dif.shproves detect-and-skip and fail-closed without Maven.Companion:
embabel-difscripted day + safeguard review.REASONS Canvas
Checklist
Manual Smoke
Template-only. Process gates unchanged when DIF or snapshots are absent.
Test Plan
./tests/test-command-specs.sh./tests/test-optional-dif.sh./scripts/generate-command-adapters.sh --check