Avoid unnecessary exponential wait computation#654
Merged
Conversation
Once an exponential wait exceeds its configured maximum, calculate the threshold logarithmically and return the cap without constructing an ever larger integer power. Add a regression test that rejects power evaluation past the cap. Fixes jd#526
jd
approved these changes
Jul 13, 2026
Contributor
Merge Queue Status
This pull request spent 13 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_exponential(max=...)still computesexp_base ** attempt_numberon every retry after reaching the cap, making each later retry increasingly expensive during long-running polling. This checks the logarithmic threshold first and returns the configured cap without constructing the large integer; the regression test proves the power operation is skipped.Fixes #526.