CLOUD-1867 update datavirt-app-config secret to use new src location

[bdecoste]

No description provided.

[rcernich]

I think this was a miss from when we removed the copy to $home/source. I think we should be copying the database files to $jboss_home/data instead (work was done to make this work correctly too).

[bdecoste]

Where do you want to add the copy logic? In assemble? The data directory is not currently copying CONTEXT_DIR/data to JBOSS_HOME. It's only in /tmp/src

[rcernich]

Nevermind. It looks like this was never added into the s2i assemble logic. I thought we modified the assemble logic so that it automatically copied $source/data into $jboss_home/standalone/data, but it looks like it never got added. I think we should be defaulting APP_DATADIR to "data" to make this work OOTB for everything, but...

That said, we'd need to be sure the source is always copied into /tmp/source and that the directory persists after the build is complete.

[bdecoste]

We probably should add it to assemble as /tmp is transient, right?

[rcernich]

I think what we need to do here is default APP_DATADIR to "data" and if there's a $LOCAL_SOURCE_DIR/$APP_DATADIR directory, we copy it into the default data directory, which should be $JBOSS_HOME/data.