Skip to content

Kiosk: selective HA iOS upstream fixes (WebSocket, lifecycle, auth, WebView) - #4

Draft
jaipur2001 wants to merge 22 commits into
kiosk-mainfrom
fix/kiosk-upstream-2026-10-12
Draft

jaipur2001 wants to merge 22 commits into
kiosk-mainfrom
fix/kiosk-upstream-2026-10-12

Conversation

@jaipur2001

Copy link
Copy Markdown
Owner

Scope

Selective upstream backports onto the existing Kiosk branch (no upstream merge).

Safeguards

  • kiosk-main remains unchanged until CI and real-device doorbell/kiosk tests are accepted.
  • No modifications to camera, audio-session, notification payloads, signing profiles or kiosk-specific doorbell code.
  • Added upstream-specific unit coverage for refresh token rejection, URL recovery, foreground external-bus replay and iPad full-screen behavior.

Validation before merge

  • GitHub CI lint, Xcode build, unit tests
  • Wake after background/foreground and test external-bus reconnect
  • HA restart: dashboard and doorbell dialog without Home-button workaround
  • Camera/RTSP/MJPEG + microphone/backchannel; app audio and notification MP3
  • iPad full-screen/kiosk no status strip
  • 10+ minute WebSocket stability, then prolonged soak
  • Signed kiosk IPA via the dedicated workflow_dispatch only after checks

Upstream PR references: home-assistant#6038, home-assistant#5985, home-assistant#6012, home-assistant#6034, home-assistant#6008.

Copy link
Copy Markdown
Owner Author

CI note: lint currently fails in yamllint --strict . on pre-existing line-length/trailing-space errors in .github/workflows/kiosk_ipa.yml (unchanged by this PR). This prevents the downstream SwiftLint/SwiftFormat steps from running; it does not establish a failure of the selective upstream backports. The Xcode test job runs independently. The signing workflow was intentionally left untouched.

Copy link
Copy Markdown
Owner Author

CI investigation (2026-10-12): run 38225631862 successfully executed 4,482 iOS unit tests with 0 failures. The job then failed with xcodebuild exit 70 because the Apple Watch Series 11 (46mm) watchOS simulator is not installed on the xcode-27 runner. The watch snapshot suite was not executed; this is not an iOS-app regression. Commit 7a38217 now conditionally runs WatchApp snapshots only if that exact simulator is available, and emits a visible warning/step summary otherwise. The production kiosk-main branch is unchanged; real iPad doorbell, AV, and HA-restart validation remain outstanding.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage of this pull request is below 90%

The unit tests run 84.10% of the lines this pull request
adds or changes (164 of 195 coverable lines).

The per-file breakdown, and the changed lines no test runs, are in the
job summary. Adding tests for those lines and pushing dismisses this
review automatically.

Lines that carry no executable code, and files the unit test targets do not
build, are not counted. If the new code genuinely cannot be unit tested, a
maintainer can dismiss this review.

@github-actions
github-actions Bot dismissed their stale review October 12, 2026 12:39

Patch coverage is now 91.28%, at or above the 90% threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant