Skip to content

Raise the minimum Rust version to 1.95 and check it in CI - #26

Open
Skyfuller1303 wants to merge 1 commit into
itrycodinganditsbad:mainfrom
Skyfuller1303:msrv-195
Open

Skyfuller1303 wants to merge 1 commit into
itrycodinganditsbad:mainfrom
Skyfuller1303:msrv-195

Conversation

@Skyfuller1303

@Skyfuller1303 Skyfuller1303 commented Nov 4, 2026 •

Copy link
Copy Markdown

Cargo.toml declares rust-version = "1.94", but the workspace no longer builds on 1.94. Main already shows two reasons:

  • The locked egui 0.36.2 crates require rustc 1.95. On 1.94, cargo check --workspace --all-targets --locked stops before compiling:

    error: rustc 1.94.1 is not supported by the following packages:
      ecolor@0.36.2 requires rustc 1.95
      eframe@0.36.2 requires rustc 1.95
      egui@0.36.2 requires rustc 1.95
      ...
    
  • With --ignore-rust-version, it then fails on the if let guard in crates/sync/src/engine/apply.rs:628:

    error[E0658]: `if let` guards are experimental
    

CI only builds with the newest stable compiler, so neither showed up.

What

  • rust-version = "1.95" in the workspace Cargo.toml. 1.95 is the version the whole workspace builds on.
  • A new CI job msrv on ubuntu-24.04. It installs the egui/winit headers and runs cargo check --workspace --all-targets --locked with exactly the declared toolchain (dtolnay/rust-toolchain@1.95), so the declared version stays true. A comment says to keep it equal to rust-version.

No code or dependency changes. Downgrading egui to keep 1.94 seemed the wrong trade.

Testing

  • cargo check --workspace --all-targets --offline --locked on Rust 1.95.0: passes (Windows).
  • The same on 1.94.1: refused as above.
  • The new job's YAML parses. It has not run on GitHub yet; this PR's CI run is its first.

The workspace declared rust-version 1.94, but it no longer builds there: the
locked egui 0.36.2 crates (ecolor, eframe, egui, egui-wgpu, egui-winit,
egui_kittest, emath, epaint, epaint_default_fonts) require rustc 1.95, and the
`if let` guard in crates/sync/src/engine/apply.rs needs it too. CI only builds
with the newest stable compiler, so this went unnoticed.

Declare 1.95, which the whole workspace checks on, and add a job that runs
`cargo check --workspace --all-targets --locked` with exactly that toolchain,
so the declared version stays true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant