Repository navigation
Raise the minimum Rust version to 1.95 and check it in CI - #26
Open
Skyfuller1303 wants to merge 1 commit into
Open
Skyfuller1303 wants to merge 1 commit into
Skyfuller1303 wants to merge 1 commit into
Conversation
The workspace declared rust-version 1.94, but it no longer builds there: the locked egui 0.36.2 crates (ecolor, eframe, egui, egui-wgpu, egui-winit, egui_kittest, emath, epaint, epaint_default_fonts) require rustc 1.95, and the `if let` guard in crates/sync/src/engine/apply.rs needs it too. CI only builds with the newest stable compiler, so this went unnoticed. Declare 1.95, which the whole workspace checks on, and add a job that runs `cargo check --workspace --all-targets --locked` with exactly that toolchain, so the declared version stays true.
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.tomldeclaresrust-version = "1.94", but the workspace no longer builds on 1.94. Main already shows two reasons:The locked egui 0.36.2 crates require rustc 1.95. On 1.94,
cargo check --workspace --all-targets --lockedstops before compiling:With
--ignore-rust-version, it then fails on theif letguard incrates/sync/src/engine/apply.rs:628:CI only builds with the newest stable compiler, so neither showed up.
What
rust-version = "1.95"in the workspaceCargo.toml. 1.95 is the version the whole workspace builds on.msrvon ubuntu-24.04. It installs the egui/winit headers and runscargo check --workspace --all-targets --lockedwith exactly the declared toolchain (dtolnay/rust-toolchain@1.95), so the declared version stays true. A comment says to keep it equal torust-version.No code or dependency changes. Downgrading egui to keep 1.94 seemed the wrong trade.
Testing
cargo check --workspace --all-targets --offline --lockedon Rust 1.95.0: passes (Windows).