Skip to content

[FIX] l10n_latam_check_ux: recompute issue_state of the whole hierarchy - #1180

Closed
cav-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-t-72542-cav
Closed

cav-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-t-72542-cav

Conversation

@cav-adhoc

Copy link
Copy Markdown
Contributor

Parte del review de multicompañía / branches de l10n_latam_check_ux (tarea 72542, subtarea de la 72037).

Qué corrige

Al tocar "Permitir conciliación" en una cuenta compartida por el árbol de compañías, el recálculo del issue_state almacenado se salteaba los cheques de las branches que el usuario no tenía habilitadas y los dejaba desincronizados. Ahora el search es sudo: es un recálculo técnico, no una consulta del usuario.

models/account_account.py

@roboadhoc

Copy link
Copy Markdown
Contributor

Pull request status dashboard

account.account is shared between the parent company and its branches, so
toggling "Allow Reconciliation" on the checks suspense account has to recompute
the stored issue_state of every check on that account. The search ran without
sudo and the record rule of the check left out the branches the user has not
enabled, so their issue_state — the field that decides whether the check shows
as issued or debited — was left desynchronized.
@rov-adhoc

Copy link
Copy Markdown
Contributor

@roboadhoc r+ nobump

roboadhoc pushed a commit that referenced this pull request Oct 9, 2026
account.account is shared between the parent company and its branches, so
toggling "Allow Reconciliation" on the checks suspense account has to recompute
the stored issue_state of every check on that account. The search ran without
sudo and the record rule of the check left out the branches the user has not
enabled, so their issue_state — the field that decides whether the check shows
as issued or debited — was left desynchronized.

closes #1180

Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
roboadhoc pushed a commit that referenced this pull request Oct 9, 2026
account.account is shared between the parent company and its branches, so
toggling "Allow Reconciliation" on the checks suspense account has to recompute
the stored issue_state of every check on that account. The search ran without
sudo and the record rule of the check left out the branches the user has not
enabled, so their issue_state — the field that decides whether the check shows
as issued or debited — was left desynchronized.

closes #1180

Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
@roboadhoc roboadhoc closed this Oct 9, 2026
@roboadhoc
roboadhoc deleted the 19.0-t-72542-cav branch October 9, 2026 15:50

This branch was previously deployed

1 inactive deployment
merge — 5fab94bf Deployed Oct 9, 2026 by roboadhoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants