Repository navigation
Conversation
Contributor
|
|
cav-adhoc
force-pushed
the
19.0-t-72540-cav
branch
2 times, most recently
from
August 19, 2026 19:15
0ab4698 to
b2358bf
Compare
…s them The rejected journal had no company in its domain and the wizard had no company_id nor _check_company_auto, so the payments could be created in another company of the branch tree. check_company does not catch it because Odoo accepts records of a parent company on a branch, so the _compute_company_id of the check followed the payment and the check migrated of company as a side effect of the rejection, leaving the customer debt in the wrong company. Restrict the journal to the company of the checks and validate it on confirm.
cav-adhoc
force-pushed
the
19.0-t-72540-cav
branch
from
October 5, 2026 17:23
b2358bf to
8286ff6
Compare
Contributor
|
@roboadhoc r+ bump |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 9, 2026
…s them The rejected journal had no company in its domain and the wizard had no company_id nor _check_company_auto, so the payments could be created in another company of the branch tree. check_company does not catch it because Odoo accepts records of a parent company on a branch, so the _compute_company_id of the check followed the payment and the check migrated of company as a side effect of the rejection, leaving the customer debt in the wrong company. Restrict the journal to the company of the checks and validate it on confirm. closes #1178 Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
Oct 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parte del review de multicompañía / branches de
l10n_latam_check_ux(tarea 72540, subtarea de la 72037).Qué corrige
El wizard de rechazo aceptaba un diario de cualquier compañía.
check_companyno lo frena porque en branches Odoo acepta registros de la compañía padre sobre una hija, así que los pagos se creaban en otra compañía, el_compute_company_iddel cheque lo seguía y el cheque migraba de compañía como efecto colateral del rechazo, con la deuda del cliente quedando en la compañía equivocada. Ahora el dominio del diario se acota a la compañía del cheque y se valida al confirmar.wizards/account_check_reject_wizard.py,wizards/account_check_reject_wizard_view.xmlTests
tests/test_check_transfers.py::test_reject_wizard_requires_a_journal_of_the_check_company, verificado en rojo sin el fix y en verde con él.