Repository navigation
Conversation
Contributor
|
|
cav-adhoc
force-pushed
the
19.0-t-72538-cav
branch
from
October 5, 2026 17:23
0f67c83 to
4a1f96e
Compare
…archy _credit_debit_get of core aggregates the journal items with child_of over the root company and bypass_access, but the checks were added up for the active company only: standing on the parent company the partner credit included the invoices of the branch and not its checks, so add_check_credit stopped making sense on any installation with branches. Checks of a company of the tree that the user has not enabled were silently dropped as well.
cav-adhoc
force-pushed
the
19.0-t-72538-cav
branch
from
October 9, 2026 18:05
4a1f96e to
2d4e6a8
Compare
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 13, 2026
…archy _credit_debit_get of core aggregates the journal items with child_of over the root company and bypass_access, but the checks were added up for the active company only: standing on the parent company the partner credit included the invoices of the branch and not its checks, so add_check_credit stopped making sense on any installation with branches. Checks of a company of the tree that the user has not enabled were silently dropped as well. closes #1176 Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parte del review de multicompañía / branches de
l10n_latam_check_ux(tarea 72538, subtarea de la 72037).Qué corrige
El crédito por cheques del partner se sumaba solo con la compañía activa, mientras el
_credit_debit_getde core agrega los apuntes conchild_ofsobre la raíz ybypass_access: parado en la casa central se veían las facturas de la sucursal pero no sus cheques, y los cheques de una compañía del árbol que el usuario no tenía habilitada se descartaban en silencio. Ahora usachild_ofsobreroot_id+sudo.models/res_partner.pyTests
tests/test_check_transfers.py::test_partner_check_credit_includes_branch_checks, verificado en rojo sin el fix y en verde con él.