Skip to content

Peer facet ILLDEV-433 - #24

Merged
skomorokh merged 1 commit into
mainfrom
facet-async-only-illdev-433
Jul 27, 2026
Merged

Peer facet ILLDEV-433#24
skomorokh merged 1 commit into
mainfrom
facet-async-only-illdev-433

Conversation

@skomorokh

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for a “peer” facet filter on Patron Requests (supplier for request-side, requester for supply-side), including server-side typeahead narrowing of facet options and URL/CQL integration.

Changes:

  • Extend CQL-building utilities to support peer filter groups and generate facet-option-list CQL (including safe term escaping).
  • Add a peer facet query to PatronRequestsRoute and render a new peer accordion in Filters with custom option formatting/highlighting.
  • Improve Okapi ky mocking to handle searchParams and add coverage for the new behaviors.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ui-rs/src/util/buildPatronRequestsCql.js Adds supplier/requester filter groups, term escaping, and facet-options CQL builder.
ui-rs/src/util/buildPatronRequestsCql.test.js Adds unit tests for peer filters, escaping, and facet-options CQL behavior.
ui-rs/src/test/okapiKyMock.js Enhances mock to fold searchParams into effective URLs and support per-URL dynamic responses.
ui-rs/src/routes/PatronRequestsRoute.js Adds peer facet query + typeahead state and injects peer options into filterOptions.
ui-rs/src/routes/PatronRequestsRoute.test.js Adds integration tests for peer facet selection, missing selections, narrowing, and remount term reset.
ui-rs/src/components/PatronRequests/PatronRequests.js Threads new peerFacet prop through to Filters.
ui-rs/src/components/PatronRequests/Filters.js Renders peer facet accordion and custom option rendering/highlighting.
ui-rs/src/components/PatronRequests/Filters.css Adds styling for option layout and prefix highlighting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui-rs/src/routes/PatronRequestsRoute.js
Comment thread ui-rs/src/routes/PatronRequestsRoute.js
@skomorokh
skomorokh marked this pull request as ready for review July 27, 2026 16:52
@skomorokh
skomorokh merged commit 2594708 into main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants