Peer facet ILLDEV-433 - #24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a “peer” facet filter on Patron Requests (supplier for request-side, requester for supply-side), including server-side typeahead narrowing of facet options and URL/CQL integration.
Changes:
- Extend CQL-building utilities to support peer filter groups and generate facet-option-list CQL (including safe term escaping).
- Add a peer facet query to
PatronRequestsRouteand render a new peer accordion inFilterswith custom option formatting/highlighting. - Improve Okapi ky mocking to handle
searchParamsand add coverage for the new behaviors.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui-rs/src/util/buildPatronRequestsCql.js | Adds supplier/requester filter groups, term escaping, and facet-options CQL builder. |
| ui-rs/src/util/buildPatronRequestsCql.test.js | Adds unit tests for peer filters, escaping, and facet-options CQL behavior. |
| ui-rs/src/test/okapiKyMock.js | Enhances mock to fold searchParams into effective URLs and support per-URL dynamic responses. |
| ui-rs/src/routes/PatronRequestsRoute.js | Adds peer facet query + typeahead state and injects peer options into filterOptions. |
| ui-rs/src/routes/PatronRequestsRoute.test.js | Adds integration tests for peer facet selection, missing selections, narrowing, and remount term reset. |
| ui-rs/src/components/PatronRequests/PatronRequests.js | Threads new peerFacet prop through to Filters. |
| ui-rs/src/components/PatronRequests/Filters.js | Renders peer facet accordion and custom option rendering/highlighting. |
| ui-rs/src/components/PatronRequests/Filters.css | Adds styling for option layout and prefix highlighting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skomorokh
marked this pull request as ready for review
July 27, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.