Require rouge 5.1 or later - #276
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
P-SiZK
requested review from
a team and
kimkim0814
and removed request for
a team
October 1, 2026 07:38
kimkim0814
approved these changes
Oct 6, 2026
| DEFAULT_LANGUAGE = "text" | ||
| DEFAULT_TIMEOUT = Float::INFINITY | ||
| DEFAULT_OPTION = "html_legacy" | ||
| FORMATTER = Rouge::Formatters::HTMLPygments.new(Rouge::Formatters::HTML.new) |
Member
There was a problem hiding this comment.
📝
Renamed since it now holds a formatter instance, not an option string.
It also matches the formatter param name in Rouge.highlight.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump rouge to 5.1 and stop using the
html_legacyformatter, which is deprecated in rouge 5.This replaces #275.
How
~> 5.1HTMLPygments.new(HTML.new)as the formatter inSyntaxHighlighthtml_legacyWhy
#275 only widens the requirement to
>= 4.2, < 6.0, so rouge 5.1 still prints a deprecation warning forHTMLLegacyto stderr.Refs