Skip to content

Allow skipping hero recruitment animation on click - #10835

Open
pazam-h2 wants to merge 5 commits into
ihhub:masterfrom
pazam-h2:hero-recruit-animation-skip
Open

Allow skipping hero recruitment animation on click#10835
pazam-h2 wants to merge 5 commits into
ihhub:masterfrom
pazam-h2:hero-recruit-animation-skip

Conversation

@pazam-h2

Copy link
Copy Markdown
Contributor

This PR allows the player to skip the visual hero recruitment animation in the castle dialog by left-clicking or right-clicking while the animation is still playing.

The recruitment sound is not interrupted and continues playing until the end.

Currently- after recruiting a hero from a castle, the player has to wait until the full hero fade-in animation finishes before interacting with the castle dialog again.
This can feel unnecessarily interruptive, especially compared to other castle actions.

Based on feedback from @zense, the intended behavior is that a click should finish the visual animation while the sound continues playing to the end.

Behavior after this change
If the player does nothing, the hero recruitment animation plays normally.
If the player left-clicks or right-clicks inside the castle dialog during the animation, the visual animation finishes immediately.
The first click only finishes the animation and does not trigger another castle action.
After that, the castle dialog becomes fully interactable again.
The recruitment sound continues playing normally.

  • This change does not shorten the animation by default. It only allows the player to skip the visual waiting period through interaction.
2026-06-15.01-15-31.mp4

relates to #10834

@Branikolog

Copy link
Copy Markdown
Collaborator

Hi, @pazam-h2
I personally think that this implementation is the way to go. A single click should promptly finish the animation, after which the player can choose another object or button to interact with.

I'm looking forward to testing the changes once the PR is compiled.

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff labels Jun 22, 2026
@ihhub ihhub added this to the 1.1.17 milestone Jun 22, 2026
@ihhub
ihhub requested review from Branikolog and ihhub June 22, 2026 04:57
Comment thread src/fheroes2/castle/castle_dialog.cpp Outdated
@pazam-h2
pazam-h2 force-pushed the hero-recruit-animation-skip branch from 17f5154 to 0682f51 Compare June 22, 2026 08:30
@Branikolog

Copy link
Copy Markdown
Collaborator

Hi, @pazam-h2 and @ihhub

I've done a couple of tests and the intended behaviour works correctly. However, with the increased animation speed from the recent PR, I barely need to click, as the animation finishes quite quickly. Probably, some competitive online players might benefit from this improvement.

The only addition that comes to mind regarding the logic here is to allow skipping with any key from the keyboard. For example, pressing Esc a couple of times could instantly exit the castle screen.
This would make interaction faster without relying solely on mouse input.

How do you think?

@pazam-h2

Copy link
Copy Markdown
Contributor Author

@Branikolog -
Yeah, no objections from me.

I'll add the 'any key to stop animation' part.

@ihhub ihhub modified the milestones: 1.1.17, 1.1.18 Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement New feature, request or improvement ui UI/GUI related stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants