Allow skipping hero recruitment animation on click - #10835
Conversation
|
Hi, @pazam-h2 I'm looking forward to testing the changes once the PR is compiled. |
17f5154 to
0682f51
Compare
|
I've done a couple of tests and the intended behaviour works correctly. However, with the increased animation speed from the recent PR, I barely need to click, as the animation finishes quite quickly. Probably, some competitive online players might benefit from this improvement. The only addition that comes to mind regarding the logic here is to allow skipping with any key from the keyboard. For example, pressing Esc a couple of times could instantly exit the castle screen. How do you think? |
|
@Branikolog - I'll add the 'any key to stop animation' part. |
This PR allows the player to skip the visual hero recruitment animation in the castle dialog by left-clicking or right-clicking while the animation is still playing.
The recruitment sound is not interrupted and continues playing until the end.
Currently- after recruiting a hero from a castle, the player has to wait until the full hero fade-in animation finishes before interacting with the castle dialog again.
This can feel unnecessarily interruptive, especially compared to other castle actions.
Based on feedback from @zense, the intended behavior is that a click should finish the visual animation while the sound continues playing to the end.
Behavior after this change
If the player does nothing, the hero recruitment animation plays normally.
If the player left-clicks or right-clicks inside the castle dialog during the animation, the visual animation finishes immediately.
The first click only finishes the animation and does not trigger another castle action.
After that, the castle dialog becomes fully interactable again.
The recruitment sound continues playing normally.
2026-06-15.01-15-31.mp4
relates to #10834