Repository navigation
ci: merge main to release - #11843
Merged
Merged
Conversation
* refactor: extract IPR response address validation Adds some failing tests that expose a bug * fix: parse to address properly * refactor: extract address instead of just validating * test: fix broken test Test email was badly formatted and not parsing into a message as intended. The old code gave the expected result despite this. * test: move mail-related tests to tests_mail.py * test: a couple more negative test cases * test: rename test to reflect method name
| return to_addr if is_valid else None | ||
|
|
||
|
|
||
| def process_response_email(msg): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.