Change gif loop behaviour to works like most of the modern browsers - #90
Open
pawlowskim wants to merge 1 commit into
Open
Change gif loop behaviour to works like most of the modern browsers#90pawlowskim wants to merge 1 commit into
pawlowskim wants to merge 1 commit into
Conversation
-if loop meta data is not set, play gif once -increased loop count by 1 to works the same way like on android, chrome, safari, opera
|
This is the GIF in browser behavior, but will break APNG and Animated WebP behavior in browser. You can check that both these set 0 by default to infinity loop in Chrome 59, Safari(Not Animated WebP), firefox.. So a better solution is to set that loop count on your logic level but not the Decoder Level.. You can override that loop count when using GIF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I was testing YYImage with react-native port (https://www.npmjs.com/package/react-native-yyimage) against loop behaviour. I found out that, library sets infinity loops when there is no loop count (Animation iterations from exiftool) in gif metadata. Other browsers sets default loop count = 1 when no metadata available. I have tested the same looped gifs on android, chrome, safari opera and mozilla FF and iOS. I don't know if you want to change default behaviour of YYImage but for my needs I changed it to works like the same way like on: