IBX-12530: Built integration test schema through SchemaBuilderEvent - #146
Draft
Steveb-p wants to merge 2 commits into
Draft
IBX-12530: Built integration test schema through SchemaBuilderEvent#146Steveb-p wants to merge 2 commits into
Steveb-p wants to merge 2 commits into
Conversation
Steveb-p
changed the title
Steveb-p
force-pushed
the
database-schema-hook-4.6
branch
from
September 9, 2026 12:35
1f284c1 to
cc756f4
Compare
ibexa/test-core#43 rebuilds DatabaseSchemaHook on SchemaBuilderInterface::buildSchema() instead of importing raw schema.yaml files, so the test kernel now has to register DoctrineSchemaBundle (which provides SchemaBuilderInterface) and IbexaRepositoryInstallerBundle (which holds core's own BuildSchemaSubscriber).
Points CI at the branch that rebuilds DatabaseSchemaHook, so this PR's tests can run before that PR merges. Must be removed before merging.
Steveb-p
force-pushed
the
database-schema-hook-4.6
branch
from
September 9, 2026 12:54
cc756f4 to
9772ba4
Compare
|
Steveb-p
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This branch includes a temporary commit (
dependencies.json) that points CI atibexa/test-core#43 so tests can run before that PR merges. Must be removed before merging
this PR.
Related PRs:
The other 25 package PRs (all must land together with #43)
Description:
ibexa/test-core#43 rebuilds
DatabaseSchemaHookonSchemaBuilderInterface::buildSchema(). Itpreviously imported raw
schema.yamlfiles listed throughSchemaFilesProviderInterfaceviaLegacySchemaImporter, which never dispatchesSchemaBuilderEvent— so a package contributingits schema through the event rather than a file was never covered by integration tests, even
though the event is what
ibexa:install's legacy path uses in production.Building through the event needs
DoctrineSchemaBundle(forSchemaBuilderInterface) andIbexaRepositoryInstallerBundle(which carries core's ownBuildSchemaSubscriber— it livesthere rather than in
IbexaCoreBundle, and without it the event yields every other package'stables but none of core's). #43 registers both in
IbexaTestKernelitself, so no package hasto add them, and this PR does not.
What is left is the part that is genuinely specific to this package:
UserSchemaFilesProvideronly ever fed the old hook, so it and its DI registration are gone. That was the only service intests/integration/Resources/services.php, so the file and its$loader->load()call go too.Nothing outside
tests/changes.For QA:
composer test-integration— 9 tests / 20 assertions, green.