IBX-12046: Removed Symfony 8 deprecated code usage - #54
Open
ViniTou wants to merge 1 commit into
Open
Conversation
Adds explicit nullable (?) type-hints to implicit nullable parameters (Type $param = null) in ChangeArgumentTypeRector test fixtures, which is deprecated as of PHP 8.4 and removed in PHP 9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Adds explicit
?nullable markers to parameters typedType $param = nullwithout it, which PHP 8.4 deprecates (implicit nullable types) and PHP 9 will remove. Scope for this package is narrow: the static scan only found this pattern insideChangeArgumentTypeRector's test fixtures (tests/lib/Rule/ChangeArgumentTypeRector/Fixture/*.php.inc), on thearray $targets = nullparameter that is untouched context in those before/after fixtures (not the parameter the rule rewrites). Nosrc/occurrences exist. No Rector rules/sets were added or changed,rector/rectorand other composer constraints were left untouched.For QA:
composer test-unit(87 tests, 99 assertions) — green.composer phpstan— no errors.composer check-cs— no files need fixing.Documentation:
N/A — test-fixture-only change, no public API impact.