IBX-12173: Added Varnish 9 VCL - #84
Conversation
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Thank you @vidarl! Side note: since 5.0 we most likely need that in https://github.com/ibexa/cloud/blob/5.0/resources/upsun/common/5.0/.platform/varnish.vcl too.
bnowak
left a comment
bnowak
left a comment
There was a problem hiding this comment.
Approved to ublock topic, based on it's 1:1 copy between versions.
I don't know vcl much, so if you want to have more confidence, please wait for some more reviewers 😉
@konradoboza :PR created : ibexa/cloud#12 |
83221ba to
4e98423
Compare
|
Sonar Cloud complains about Github actions can be ignored, ref discussion on |
|
I am re-requesting reviews on this one, as I have added two more commits. |
barw4
left a comment
barw4
left a comment
There was a problem hiding this comment.
+1 but aren't we missing some yml config as CI shows?
|
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
Just a few nitpicks for browser-tests.yaml
| on: | ||
| push: | ||
| branches: | ||
| - main |
| test-setup-phase-1: '--mode=standard --profile=httpCache --suite=setup-symfony-cache' | ||
| test-setup-phase-2: '--mode=standard --profile=httpCache --suite=setup' | ||
| secrets: | ||
| AUTOMATION_CLIENT_ID: ${{ secrets.AUTOMATION_CLIENT_ID }} |
There was a problem hiding this comment.
'secrets:' can be streamlined to something like: https://github.com/ibexa/page-builder/blob/6.0/.github/workflows/browser-tests.yaml#L19
6 participants
Caution
DO-NOT-MERGE : PR contains TMP commit with dependencies.json for making CI green
Caution
This PR cannot be merged up as-is as vcl files are different in here vs 5.0. Code for 5.0 is prepared in separate branch:
IBX-12173_support_for_varnish9_50Caution
I based this on IBX-12244-varnish7-vcl-hit for the time being as it is dependent on #86 . However, this one should be merged into 4.6 after #86, not merged into IBX-12244-varnish7-vcl-hit.
Related PRs:
Description:
Adds
docs/varnish/vcl/varnish9.vclfor Varnish 9. VCL 4.1 syntax is unchanged between Varnish 7 and 9, so this file isidentical to
varnish7.vclapart from the header comment.Note:
The SonarCloud warnings are false positives, claiming full commit SHA hash should be used for GitHub actions. But they refer to ibexa repos and can be considered safe
For QA:
Documentation: