IBX-11939: Fix tagged migrations breaking when enable_service_migrations is false - #4
Merged
Merged
Conversation
…ons is false RegisterMigrationsPass bound every IbexaMigrationTag-tagged migration's Connection/LoggerInterface constructor arguments to DoctrineMigrationsBundle's doctrine.migrations.connection/doctrine.migrations.logger services. Those two services are removed from the container entirely when enable_service_migrations is false, which made container compilation fail with a "non-existent service" error for any project not enabling that flag. Source both values from the always-available doctrine.migrations.dependency_factory via two new Ibexa-owned services (ibexa.doctrine_migrations.connection/.logger) instead, since doctrine.* service IDs belong to DoctrineMigrationsBundle.
6 tasks
Collaborator
Author
|
5.0 tier: #5 |
barw4
approved these changes
Jul 31, 2026
konradoboza
approved these changes
Jul 31, 2026
ViniTou
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
RegisterMigrationsPassbound everyIbexaMigrationTag-tagged migration'sConnection/LoggerInterfaceconstructor arguments to DoctrineMigrationsBundle'sdoctrine.migrations.connection/doctrine.migrations.loggerservices. Those two services are removed from the container entirely byDoctrineMigrationsExtension::load()whenenable_service_migrationsisfalse, so any tagged migration (e.g.ibexa/core'sInstallSchemaMigration) made container compilation fail with:for any project not explicitly enabling that flag. Found while investigating a Behat CI failure on ibexa/core#785 —
InstallSchemaMigrationextendsDoctrine\Migrations\AbstractMigration, whose constructor requires both aConnectionand aLoggerInterface, so this wasn't an optional convenience binding.Fix: both are now sourced from the application's own
doctrine.migrations.dependency_factory(registered unconditionally by DoctrineMigrationsBundle regardless ofenable_service_migrations) via two new Ibexa-owned services —ibexa.doctrine_migrations.connectionandibexa.doctrine_migrations.logger— rather than DoctrineMigrationsBundle's own aliases.doctrine.*service IDs belong to that bundle, not to Ibexa, to redefine.