Conversation
A button-triggered multi-select filter built on the dropdown partial: the base template gains widget and footer blocks, the TS base resolves its widget nodes through an overridable hook so a trigger button can replace the input-like widget, and FilterDropdown extends DropdownMultiInput to keep the select sync, search and keyboard handling while rendering the counter or single-value summary, aria-expanded and the Clear action. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
IBX-12475-dropdown-option-groups; only the top commit belongs to this PR.Description:
Twig twin of the new
FilterDropdown:<twig:ibexa:filter_dropdown name label :items type value hasSearch disabled>extends the dropdown partial, which gainswidgetandfooterblocks. The TS base now resolves its widget nodes through an overridable hook, so a trigger<button>can stand in for the input-like widget;FilterDropdownextendsDropdownMultiInputand keeps the<select multiple>sync, search and keyboard handling while updatingaria-expanded, the counter / single-value summary and the Clear action. No consumer yet (first adopter: the "More filters" toggler ofadaptive_filters.html.twig— follow-up).For QA:
No back-office consumer in this PR. Verified on a scratch page: all four types initialise, open/close, checking items updates the counter and the hidden select, Clear empties and disables itself, search shows "No results found", the dashboard type shows "Filter: " at 32px, a disabled trigger never opens.
Documentation: