IBX-12046: Removed Symfony 8 deprecated code usage - #44
Open
ViniTou wants to merge 1 commit into
Open
Conversation
Removed the unused symfony/templating dependency (Twig is already provided via ibexa/core); no direct usages of Symfony\Component\Templating existed in src or tests, only the unrelated Ibexa\DesignEngine\Templating namespace. Full static scan for other Symfony 8 deprecation patterns (Request::get(), voters, constraints, Twig extension/loader return types, etc.) found no further matches in this repo. Unit suite passes with 0 direct/indirect/self deprecations under symfony/phpunit-bridge; PHPStan and CS clean.
|
konradoboza
approved these changes
Sep 11, 2026
mikadamczyk
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
symfony/templatingdependency fromcomposer.json. It was dead: no code insrc/testsusesSymfony\Component\Templating— the onlyTemplating-named hits are the repo's ownIbexa\DesignEngine\Templatingnamespace (template path registry, name resolver, Twig theme loader). Twig itself is already provided transitively viaibexa/core.Request::get(), Security voters/UserChecker, Validator constraints,!tagged, Serializer/Routing annotations,ArgumentValueResolverInterface, nestedOptionsResolverdefaults, implicit-nullable params, Twig extension/loader return types) — no further matches in this repo.composer updateafter the removal resolves cleanly on Symfony 7.4.18 (symfony/templating6.4.24 remains installed only transitively viaibexa/core, which still requires it directly).For QA:
composer install/composer updateshould succeed and the bundle should function as before (Twig theme fallback, template path resolution, data collector).Documentation:
N/A