IBX-12046: Removed Symfony 8 deprecated code usage - #29
Open
ViniTou wants to merge 1 commit into
Open
Conversation
Prefixed the implicit-nullable `string $schedule = null` parameter in CronJobsRegistry::addCronJob() with `?` to avoid the PHP 8.4 deprecation. No other Symfony 8 deprecation patterns (voters, security constraints, Request::get(), OptionsResolver nested defaults, Console AsCommand/defaultName, templating/property-info) were found in this repo.
|
konradoboza
approved these changes
Sep 11, 2026
mikadamczyk
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Static and live scans of this repo against Symfony 7.4/PHP 8.4 turned up a single hit: an implicit-nullable parameter,
string $schedule = null, inCronJobsRegistry::addCronJob(), which PHP 8.4 deprecates. It is now declared?string $schedule = null. No other Symfony 8 deprecation patterns (security voters/constraints,Request::get(), OptionsResolver nested defaults, ConsoleApplication::add()/Command::$defaultNamestatics,symfony/templating,PropertyInfo\Type, tagged services, Serializer/Routing annotations) were found in this repo'ssrc/tests. There are no BC concerns: the parameter stays optional and nullable in both signatures, and the method has no callers within this repo. No cross-repo merge-order dependency: this is a leaf-level signature widening, not a change to an abstract/contract class other repos extend.For QA:
No functional behavior change;
addCronJob()still acceptsnullas before. Nothing to exercise beyond a normal cron job registration smoke test if desired.Documentation:
N/A — no public API/behavior change, only a type-declaration widening to remove a PHP 8.4 deprecation notice.