IBX-11778: Updated GitHub Actions workflows to org standard - #28
Open
alongosz wants to merge 8 commits into
Open
IBX-11778: Updated GitHub Actions workflows to org standard#28alongosz wants to merge 8 commits into
alongosz wants to merge 8 commits into
Conversation
- Removed the deprecated pr-assign.yaml workflow - All remaining workflows delegate to ibexa/gh-workflows reusable workflows tracked at @main, so no action bumps, runner or trigger changes were needed
- backend-ci.yaml: backport of the 5.0 Backend CI (D6) with the full standard applied — Backend CI name, bare workflow_dispatch, version-glob push trigger, checkout v7, ubuntu-26.04, shared composer-install with explicit php-version, pipefail guard; PHP 7.4 added to the cs-fix matrix; the 5.0 rector job was not backported (rector is not used on 4.6)
The backported cs-fix job runs `composer run-script check-cs`; 4.6 only had `fix-cs`, so mirror 5.0's `check-cs` (fix-cs in dry-run mode).
The 4.6 branch has no tests, yet require-dev pinned phpunit ^6.4 || ^7.0, every release of which is now blocked by Composer's security-advisory check (GHSA-vvj3-c3rp-c85p). That made the backported cs-fix job unable to install dependencies at all. 5.0 already has no phpunit requirement.
First run of check-cs on the 4.6 branch (ibexa/code-style ^1.0 now resolves to 1.3, which enforces single_blank_line_before_namespace); four files needed a blank line after the file docblock.
The 5.0 job uses PHP 8.3, but on 4.6 ibexa/code-style ^1.0 resolves to a php-cs-fixer build that supports PHP 8.2 at most. 8.1 matches the cs-fix jobs of the other 4.6 packages.
The backported cs-fix job ran on both 7.4 and 8.1. php-cs-fixer can report different results per PHP version, so a matrix makes the check ambiguous. Kept 7.4, the lowest version this branch supports, which is the php-cs-fixer recommendation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Part of the fleet-wide GHA workflow standardization (wave 9; sample: ibexa/taxonomy#444). Changes:
ubuntu-26.04.pr-assign.yamlworkflow.backend-ci.yaml— D6 backport of the 5.0 Backend CI, which on 5.0 consists of a cs-fix job and a rector job only. The cs-fix job was backported with the full standard applied (Backend CI name, bareworkflow_dispatch, version-glob push trigger, checkout v7, ubuntu-26.04, shared composer-install with explicitphp-version, pipefail guard) and PHP 7.4 added to its matrix; the rector job was not (rector is not used on 4.6).check-cscomposer script (@fix-cs --dry-run, mirroring 5.0) in a separate[Composer]commit — 4.6 only hadfix-cs, so the backported job would otherwise fail. First run of this job on 4.6: watch for pre-existing code-style findings.phpunit/phpunit ^6.4 || ^7.0dev requirement in a second[Composer]commit: the 4.6 branch has no tests, and every phpunit 6/7 release is blocked by Composer's security-advisory check (GHSA-vvj3-c3rp-c85p), which made the backported cs-fix job unable to install anything. 5.0 already has no phpunit requirement.single_blank_line_before_namespace(ibexa/code-style ^1.0 resolves to 1.3); fixed in a separate commit.ibexa/code-style ^1.0resolves to a php-cs-fixer that supports PHP 8.2 at most.For QA:
Verify CI is green.
Documentation:
No documentation required.
🤖 Generated with Claude Code