IBX-12475: Passed grouped choices through to the DS dropdown - #2067
Open
tischsoic wants to merge 1 commit into
Open
IBX-12475: Passed grouped choices through to the DS dropdown#2067tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
The adapter fell back to the legacy dropdown whenever a ChoiceType had
optgroups, because the DS dropdown only accepted a flat item list. Groups
are now normalised to {label, items} entries (deeper groups flattened into
their top-level group, preferred choices first, leaf ids deduplicated),
which the DS dropdown renders natively, so the two grouped-choice
conditions leave the bail-out list.
Co-authored-by: Claude <noreply@anthropic.com>
|
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
dropdown_ds.html.twigno longer falls back to the legacy dropdown for grouped choices. AChoiceGroupViewbecomes a{ label, items }entry (deeper groups flattened into it), preferred choices come first and leaf ids are deduplicated. Requires the design-system and design-system-twig PRs;dependencies.json/ assets branch for browser tests to follow.For QA:
/admin/role/1/policy/create→ "Choose a Policy" renders the DS dropdown with module groups; search "Content / Read", select it, continue to the limitation step. Regression spots: dropdowns withis_small(content view tabs) must still render the legacy dropdown; flat multi dropdowns (Products list → Product type filter) unchanged.Documentation: