IBX-11833: Added check if field is singular to prevent add to CT - #2060
Open
mateuszdebinski wants to merge 2 commits into
Open
IBX-11833: Added check if field is singular to prevent add to CT#2060mateuszdebinski wants to merge 2 commits into
mateuszdebinski wants to merge 2 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 3, 2026 12:08
konradoboza
reviewed
Sep 8, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Please check if cases in tests/lib/Service/MetaFieldType/MetaFieldDefinitionServiceTest.php can be merged into dataProvider as it seems the major part of those is duplicated.
mikadamczyk
reviewed
Sep 8, 2026
mateuszdebinski
force-pushed
the
IBX-11833-unpredictably-added-seo-field-when-editing-CT
branch
from
September 8, 2026 09:11
9b63bba to
e8920a2
Compare
konradoboza
reviewed
Sep 8, 2026
mateuszdebinski
force-pushed
the
IBX-11833-unpredictably-added-seo-field-when-editing-CT
branch
from
September 8, 2026 10:47
e8920a2 to
9f38089
Compare
|
konradoboza
reviewed
Sep 8, 2026
konradoboza
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
A field type could get duplicated into a Content Type when its resolved field group differed from where an existing instance already lived (e.g., SEO metadata re-added on edit). The SEO field type has an isSingular function that returns true, which means that the field can only be added once to the CT.
This PR introduces verification if field is singular before adding metafields to the CT, including the SEO field.
For QA:
Documentation: