Skip to content

IBX-10639: Aligned the table header notice icon with its label - #2056

Open
tischsoic wants to merge 1 commit into
6.0from
IBX-10639-icon-label-alignment
Open

IBX-10639: Aligned the table header notice icon with its label#2056
tischsoic wants to merge 1 commit into
6.0from
IBX-10639-icon-label-alignment

Conversation

@tischsoic

@tischsoic tischsoic commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
Question Answer
JIRA issue IBX-10639
Bug/Improvement yes
New feature no
Target version v5.0, v6.0
BC breaks no
Tests no

Description

.ibexa-table-header__notice (the "You cannot delete …" line next to a list's List (n) headline) was a plain block: its <svg> sat inline on the text baseline while the block inherited line-height: 33px from .ibexa-table-header__headline, against its own 12px text. Made it a flex row centred on its content, with gap replacing the icon's margin-right and flex-shrink: 0 so the icon keeps its size next to a long message.

Root cause is IBX-10440, which grew the legacy icons from 16px to 20px without adjusting the surrounding layout — table_header.html.twig was never migrated to a design system component, so it kept the inline <svg>.

Measured on a 6.0 build, icon glyph centre vs label cap-height centre: 1.5px low → 0.5px (a correct DS button measures 0.2px on the same page).

table_header.html.twig is shared, so this covers the notice on every admin-ui list plus the ones rendered by product-catalog, site-factory, taxonomy and friends.

Counterpart PR: https://github.com/ibexa/product-catalog/pull/1585 (the catalog filters panel, same root cause).

For QA

Any list page whose bulk delete is partly blocked — e.g. Admin → Content types → Content type groups ("You cannot delete the disabled content type groups…"), Product Catalog → Attributes, Site Factory → Sites ("You cannot delete active sites."):

  • the circled-question icon is vertically centred with the message, 8px before it;
  • on a list where nothing blocks deletion the notice is still hidden entirely;
  • the List (n) headline and the bulk actions on the right are unchanged.

Co-Authored-By: Claude <noreply@anthropic.com>
@barbaragr
barbaragr force-pushed the IBX-10639-icon-label-alignment branch from 5c30eb8 to daf7c89 Compare September 10, 2026 14:30
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants