IBX-10639: Aligned the table header notice icon with its label - #2056
Open
tischsoic wants to merge 1 commit into
Open
IBX-10639: Aligned the table header notice icon with its label#2056tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
dew326
approved these changes
Sep 3, 2026
albozek
approved these changes
Sep 3, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
barbaragr
force-pushed
the
IBX-10639-icon-label-alignment
branch
from
September 10, 2026 14:30
5c30eb8 to
daf7c89
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
.ibexa-table-header__notice(the "You cannot delete …" line next to a list'sList (n)headline) was a plain block: its<svg>sat inline on the text baseline while the block inheritedline-height: 33pxfrom.ibexa-table-header__headline, against its own 12px text. Made it a flex row centred on its content, withgapreplacing the icon'smargin-rightandflex-shrink: 0so the icon keeps its size next to a long message.Root cause is IBX-10440, which grew the legacy icons from 16px to 20px without adjusting the surrounding layout —
table_header.html.twigwas never migrated to a design system component, so it kept the inline<svg>.Measured on a 6.0 build, icon glyph centre vs label cap-height centre: 1.5px low → 0.5px (a correct DS button measures 0.2px on the same page).
table_header.html.twigis shared, so this covers the notice on every admin-ui list plus the ones rendered by product-catalog, site-factory, taxonomy and friends.Counterpart PR: https://github.com/ibexa/product-catalog/pull/1585 (the catalog filters panel, same root cause).
For QA
Any list page whose bulk delete is partly blocked — e.g. Admin → Content types → Content type groups ("You cannot delete the disabled content type groups…"), Product Catalog → Attributes, Site Factory → Sites ("You cannot delete active sites."):
List (n)headline and the bulk actions on the right are unchanged.