Rename abbreviated identifiers in hiddify core service layer for readability#5
Draft
Copilot wants to merge 1 commit into
Draft
Rename abbreviated identifiers in hiddify core service layer for readability#5Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix typo in documentation files
Rename abbreviated identifiers in hiddify core service layer for readability
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cryptic single/two-letter names in the core gRPC service layer required deep context to understand. Replaces them with self-documenting names throughout
CoreInterface, its subclasses, andHiddifyCoreService.Renamed identifiers
CoreInterfacefields & methods (propagated to all subclasses and callers):fgClient/bgClient→foregroundClient/backgroundClientisSingleChannel()→isUsingSharedChannel()isActiveFg()/isActiveBg()→isForegroundServiceActive()/isBackgroundServiceActive()isBgClientAvailable()→isBackgroundClientAvailable()HiddifyCoreServiceinternals:listenSingle()/stopListenSingle()→registerSingleStreamListener()/cancelStreamListenerByKey()cc→coreClient,key→listenerKey,stream→streamFactoryerrMsg→errorMessage,sub→subscriptionres→ purpose-specific:settingsResponse,startResponse,restartResponse,selectResponse,urlTestResponse,helloResponse,tunnelResetSucceededExample
Pure rename — no behavioral changes.
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.