feat(search): reject invalid GitHub usernames before searching - #188
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Add unit tests with vitest, and stop the app from sending a request when the typed name cannot be a GitHub username.
変更点
vitest, atest/test:watchscript, and runyarn testin theNode.js CIworkflowresolutionsentry so vitest and vite do not install two versionssrc/utils/validateUsername.tswith the GitHub username rules, covered by 20 unit testsSearchBarshows an inline error instead of searching when the name is invalid. The error only appears on submit, and clears as soon as the name changesaria-invalid,aria-describedbyandrole="alert"🤖 Generated with Claude Code