Repository navigation
PHP 8.5 error on editing a task without a time zone, removed the unused and broken TaskPicker and tasks/search/json - #338
Merged
Conversation
…ed and broken TaskPicker and `tasks/search/json`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/humhub/humhub-internal/issues/1355:
Problem
time_zone = NULL,TaskForm::init()setstimeZonetonull.TimeZoneDropdownAdditionthen usesnullas an array key, which is an error on PHP 8.5, so the edit form returns 500. On older PHP versions the form silently shows a wrong time zone.tasks/search/jsonalways returns 500.SearchController::actionJson()useswidgets\TaskPicker, an unfinished copy ofUserPickerthat referencesYii::$app->taskand a non-existentUserFilter. The model-sideTaskPickerandTaskFilterare unfinished stubs too. Nothing in the module or in other modules uses them.How to reproduce
time_zone IS NULL, open it and click Edit (PHP 8.5, debug mode on)./tasks/search/json?cguid=<space guid>(friendship module enabled).Fix
tasks/search/jsonaction,widgets\TaskPicker,models\search\TaskPickerandmodels\search\TaskFilter.