Repository navigation
Conversation
Signed-off-by: Jay Shaughnessy <jshaughn@redhat.com>
Signed-off-by: Jay Shaughnessy <jshaughn@redhat.com>
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored Playwright tests construct standalone Kiali page and API URLs. OpenShift Console exposes pages under
/ossmconsole/or native/k8s/resource tabs, and Kiali APIs through/api/proxy/plugin/ossmconsole/kiali/api. The original URLs therefore navigate to the wrong pages and send direct API requests to the wrong endpoints.Add an OSSMC-owned URL adapter that:
/apirequests through the Console service proxy, including the bare API root and query strings, without adding a second prefix to existing proxy URLs.The vendored URL helper re-exports the adapter so shared navigation, direct URL-helper calls, and API polling use the same implementation. The sync script regenerates that re-export when refreshing upstream tests.
Sub-PR for kiali#885, targeting its source branch,
hhovsepy:playwright-migration.Validation:
yarn test: 36 URL-adaptation checks and 770 existing unit tests pass. The new checks run as part of the normal unit-test command.yarn tsc -p e2e --noEmitpass after the API change.yarn lint,yarn tsc --noEmit, andyarn buildpassed for the navigation change, with existing repository warnings only..unit.tschecks are excluded from browser-test discovery.A full run against a deployed Console has not been performed.