Repository navigation
perf(aws-lambda): arm64 image ships Chrome unpacked so chunks skip the per-start unpack - #6394
Closed
miguel-heygen wants to merge 6 commits into
Closed
miguel-heygen wants to merge 6 commits into
miguel-heygen wants to merge 6 commits into
Conversation
…e per-start unpack
…age cache is primed
…before screenshot fallback
Contributor
Edit accuracy did not run: 0 of 5 shards reported results; see the shard jobs.Nothing was compared with the base branch. |
Collaborator
Author
|
Closing: the saving on later renders does not justify the slower, costlier first render after each new image. The beginFrame probe retry from this branch will land on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every cold chunk on the arm64 video function used to unpack the compressed Chrome (and its fonts, graphics libraries and system libraries) into
/tmpbefore its first browser launch. The staging step now unpacks them once, intochrome/in the image, andchromium.tsuses that copy when it exists: it points Chrome at it and setsFONTCONFIG_PATHandLD_LIBRARY_PATHthe way@sparticuz/chromiumdoes for/tmp. Fonts go tofonts/, the directory itsfonts.confalready lists.Images or zips without
chrome/(the x86 zip, SAM local) keep the existing unpack path unchanged. The compressed files stay in the image as the fallback.Checks
chromium.test.tsasserts the prepared copy is used,@sparticuz/chromiumis never asked to unpack, andLD_LIBRARY_PATHis not prepended twice.@sparticuz/chromiumwrites to/tmp.Also in this PR
timedOutseparately from a real rejection; on a timeout only, the browser is relaunched and probed once more with a longer budget before falling back. A rejectedHeadlessExperimentalcommand still falls back at once. Tests fail on the previousbrowserManager.ts(3 of 3 new tests).