Repository navigation
fix(cli): recognize painted ancestor text backgrounds - #5342
Open
user-github-me wants to merge 3 commits into
Open
user-github-me wants to merge 3 commits into
user-github-me wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept visible descendant text painted by an ancestor's clipped gradient, solid color, or image when running
hyperframes check. Ordinary children on Chrome 148 and children filled by an ancestorurl()background currently receivetext_not_painteddespite visibly painting.Why
Chrome before 150 omits independently painted descendants from text masks but paints ordinary descendants. The blanket version guard rejects both. Separately, the direct-text audit accepts image backgrounds while the ancestor path rejects them, even when direct and nested headings produce identical PNGs.
Related work
Refs #5117. This addresses both follow-ups requested in the review of #5207. #5338 aligns the container browser with the CLI for the renderer failure. The complete open-PR search found no other implementation touching these audit files.
How
Inspect the child-to-mask paint properties on older Chrome, including intermediate wrappers. Match each background image to its corresponding text clip and preserve the layout-coordinate bounds check. Keep missing layered text reportable on older Chrome, along with transparent gradients, mismatched layers, SVG text, and glyphs outside the mask.
Image acceptance follows the existing direct-text policy: this audit does not decode image alpha or verify successful image loading. A transparent or unavailable image can remain outside this diagnostic's coverage.
Test plan