Skip to content

fix(render): align container Chrome with the CLI #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
user-github-me wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(render): align container Chrome with the CLI #5338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ENV CONTAINER=true
# baselines in packages/producer/tests/*/output/output.mp4 stay reproducible.
# Each Chrome stable bump shifts pixel output enough to fail PSNR. Bump this
# version together with regenerating baselines via `docker:test:update`.
RUN npx --yes @puppeteer/browsers install chrome-headless-shell@148.0.7778.167 \
RUN npx --yes @puppeteer/browsers install chrome-headless-shell@152.0.7977.30 \
--path /root/.cache/puppeteer \
&& find /root/.cache/puppeteer/chrome-headless-shell -name "chrome-headless-shell" -type f \
&& echo "chrome-headless-shell installed"
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-cloud-run/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
# Pinned deliberately. The build-stage contract probe below launches this
# exact executable and requires a renderer-ready warm-up plus a PNG-returning
# HeadlessExperimental.beginFrame before the image can build.
RUN npx --yes @puppeteer/browsers install chrome-headless-shell@148.0.7778.167 \
RUN npx --yes @puppeteer/browsers install chrome-headless-shell@152.0.7977.30 \
--path /opt/puppeteer \
&& CHS="$(find /opt/puppeteer/chrome-headless-shell -name chrome-headless-shell -type f | head -n1)" \
&& mkdir -p /opt/chrome \
Expand Down
4 changes: 2 additions & 2 deletions packages/producer/tests/chat/output/output.mp4
View file
Open in desktop
Git LFS file not shown
14 changes: 14 additions & 0 deletions packages/producer/tests/gradient-text-layered-child/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"name": "Gradient text inside a transformed child",
"description": "Both direct text and a child with its own paint layer must contribute glyphs to a background-clip: text gradient mask.",
"tags": ["regression", "css", "text"],
"minPsnr": 40,
"maxFrameFailures": 0,
"minAudioCorrelation": 0,
"maxAudioLagWindows": 1,
"renderConfig": {
"fps": 24,
"workers": 1,
"captureMode": "beginframe"
}
}
3 changes: 3 additions & 0 deletions packages/producer/tests/gradient-text-layered-child/output/compiled.html
View file
Open in desktop
Git LFS file not shown
3 changes: 3 additions & 0 deletions packages/producer/tests/gradient-text-layered-child/output/output.mp4
View file
Open in desktop
Git LFS file not shown
63 changes: 63 additions & 0 deletions packages/producer/tests/gradient-text-layered-child/src/compositions/gradient.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Direct and layered gradient text</title>
<style>
html,
body {
margin: 0;
background: #ffffff;
}

#text {
position: relative;
width: 1920px;
height: 1080px;
background: #ffffff;
}

.gradient {
position: absolute;
left: 120px;
width: 1680px;
height: 170px;
font:
120px/170px "DejaVu Sans",
sans-serif;
background: linear-gradient(#b91c1c, #1d4ed8);
-webkit-background-clip: text;
background-clip: text;
-webkit-text-fill-color: transparent;
}

#direct {
top: 180px;
}

#layered {
top: 420px;
}

/* A child with its own paint layer must still contribute glyphs to the gradient mask.
https://github.com/heygen-com/hyperframes/issues/5117 */
#layered-child {
transform: translateY(0);
}
</style>
</head>
<body>
<div
id="text"
data-composition-id="gradient-text"
data-no-timeline
data-start="0"
data-duration="1"
data-width="1920"
data-height="1080"
>
<div id="direct" class="gradient">Gradient text</div>
<div id="layered" class="gradient"><div id="layered-child">Gradient text</div></div>
</div>
</body>
</html>
37 changes: 37 additions & 0 deletions packages/producer/tests/gradient-text-layered-child/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Gradient text paint layers</title>
<style>
html,
body {
margin: 0;
width: 1920px;
height: 1080px;
background: #ffffff;
}
</style>
</head>
<body>
<div
id="root"
data-composition-id="main"
data-no-timeline
data-start="0"
data-duration="1"
data-width="1920"
data-height="1080"
>
<div
id="gradient-scene"
class="clip"
data-start="0"
data-duration="1"
data-composition-src="compositions/gradient.html"
data-composition-id="gradient-text"
data-no-timeline
></div>
</div>
</body>
</html>
1 change: 1 addition & 0 deletions packages/producer/tests/shard-schedule.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"style-7-prod": 100,
"style-8-prod": 94,
"style-9-prod": 71,
"gradient-text-layered-child": 6,
"subcomp-bare-fragment": 3,
"sub-comp-id-selector": 8,
"sub-comp-t0": 12,
Expand Down
Loading