Repository navigation
fix(cli): validate the complete TTS speed argument - #5264
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Small but real. --speed accepted values below the documented 0.1 minimum, silently used the numeric prefix of input like 1.5junk, and treated an empty value as 1.0. Parsing the whole value and checking the range the error message already states fixes all three. The tests fail on main and pass here.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyperframes tts --speedaccepts values below the stated 0.1 minimum and silently reads numeric prefixes from inputs such as1.5junkor1 2. An explicitly empty value also falls back to 1.0, starting synthesis instead of reporting invalid input.Parse the complete argument and require a finite value within 0.1–3.0. Apply the default only when the flag is omitted.
Validation: five regression cases fail on main; 49 TTS command and synthesis tests passed. The built CLI rejects below-range, trailing-text, and empty speeds before Python/model setup. CLI build/typecheck, repository lint, formatting, and test reachability passed.