Skip to content

fix(cli): route timeline project directories to inspection - #5240

Merged
jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/cli-timeline-project-directory
Oct 8, 2026
Merged

jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/cli-timeline-project-directory

Conversation

@user-github-me

Copy link
Copy Markdown
Contributor

The documented hyperframes timeline <project-dir> command rejects every project path as an unknown subcommand after timeline editing subcommands were added. Users cannot inspect another project by its advertised positional directory argument.

Distinguish inspection paths from the existing edit verbs before Citty dispatches. Keep flags parsed and validated, preserve -- for literal directory names and edit arguments, and reject extra inspection arguments through the existing diagnostic helper.

Validation: five initial end-to-end regressions fail on main; final 131 related timeline, command-registration, and argument-validation tests pass. Seventeen built-CLI cases cover absolute/relative paths with spaces, flag order, current-directory inspection, subcommand/dash-prefixed directory names, separators, unknown flags, extra/missing directories, and unchanged edit plans. Repeated inspection output is stable and all input files remain unchanged. CLI build/typecheck, root lint, formatting, comment checks, and commit hooks passed.

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This restores the documented hyperframes timeline <project-dir> form, which currently fails with "Unknown command" for any path. Flag validation and extra-argument checks still apply to inspection, and the -- handling for directories named like a verb is covered. One small trade-off: a mistyped verb now reports unexpected extra arguments rather than an unknown command. Heads up: this conflicts with #5279 in the timeline e2e test file, so whichever lands second needs a rebase.

— Rames

@jrusso1020
jrusso1020 enabled auto-merge October 8, 2026 20:08
@jrusso1020
jrusso1020 added this pull request to the merge queue Oct 8, 2026
Merged via the queue into heygen-com:main with commit ee64ebe Oct 8, 2026
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants