Repository navigation
fix(cli): normalize the audio passage the clip plays - #5222
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
jrusso1020 merged 1 commit into
jrusso1020 merged 1 commit into
Conversation
user-github-me
force-pushed
the
fix/normalize-audio-playback-start
branch
from
October 8, 2026 17:16
f03f58d to
9f0613c
Compare
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed: normalize-audio reads only data-media-start, while the render mixer and the runtime both prefer data-playback-start. So a clip trimmed with the newer attribute is measured over a different passage than the one that plays. Reusing the shared offset reader lines the two up, and the legacy attribute's validation still applies when it is the one selected. The new tests fail on main and pass here.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an audio or audible video clip with
data-playback-start,normalize-audiomeasuresdata-media-start(or zero) instead of the passage playback uses. On an 8s tone with a quiet intro and louder tail, a 2s clip starting at 4s gets a +7.6dB boost instead of the required −6.4dB reduction. A preferred offset of zero is also incorrectly overridden by the legacy attribute.Use the existing playback offset reader for the shared loudness HTML scan:
data-playback-starttakes precedence, with invalid values falling back todata-media-start. Preserve validation of a legacy offset when selected and preserve source attributes when writing the gain.Validation on current main:
Original rendering validation: persisted compositions pass lint and strict browser check. Preferred-offset and equivalent legacy-offset SDR renders contain 10 frames over 2s with matching audio measurements. Each channel is −16.1 LUFS; the existing unity mono-to-stereo upmix measures −13.1 LUFS across both channels. Repeat
--writeis byte-stable, and reference matching preserves its reference.