Repository navigation
fix(lint): parse inline script type and source attributes - #5220
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
jrusso1020 merged 1 commit into
jrusso1020 merged 1 commit into
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Verified that on main \bsrc\s*= matches data-src=, and that an unquoted type=module gets a false syntax error. Reading the real attributes through the existing decoded reader fixes both and matches how the gsap rule already detects module scripts. The tests cover the regressions and the controls, and they fail on main.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline-script syntax rule currently reads
typeandsrcwith regexes. Valid unquoted or mixed-case module/importmap/JSON types receive classic-JavaScript syntax errors, whiledata-src,data-type, or quoted metadata mentioning those attributes can suppress a real error.Read the actual decoded attributes with the existing HTML parser and normalize the type before applying the same four exemptions. Classic scripts with metadata are checked; true external scripts and exempt types keep their existing treatment, including first-attribute semantics.
Validation: