Repository navigation
fix(slideshow): validate nested hotspot entries - #5211
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed on main: a slideshow island with "hotspots": [null] passes the manifest guard and then crashes resolveSlideshow when it reads h.target, so lint throws instead of reporting slideshow_invalid. The shared parser is the right place to validate each hotspot, and it matches the existing manifest guards. Requiring numeric region values also stops non-numbers from being written into the pill's inline style. The new parser tests fail on main and pass here. Looks good.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parseable slideshow island containing
"hotspots": [null]currently passes the manifest guard and crasheshyperframes lintwithCannot read properties of null (reading 'target'). Other malformed entries can survive resolution and be classified as ready by the player.Validate each hotspot in the shared parser: require an object with string
id,label, andtarget, and validate the four finite numeric coordinates when a region is present. Both main-line and branch slides use the guard. This lets lint report its existingslideshow_invalidfinding and the player classify the existing malformed-island state before initialization.Validation:
This completes nested hotspot shape validation beside the manifest guards added in #1585 and #1594.