Repository navigation
fix(render): honor proxy environment variables in Chrome launches - #5178
Open
miguel-heygen wants to merge 2 commits into
Open
miguel-heygen wants to merge 2 commits into
miguel-heygen wants to merge 2 commits into
Conversation
miguel-heygen
marked this pull request as ready for review
October 7, 2026 10:22
miguel-heygen
marked this pull request as draft
October 7, 2026 10:24
miguel-heygen
marked this pull request as ready for review
October 7, 2026 10:35
Edit accuracy: accurate 2059 (base branch 2059), smooth 1583 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (3)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome render launches now translate
HTTP_PROXY,HTTPS_PROXY, andALL_PROXYinto native proxy settings through one shared resolver. Lowercase variables take precedence,NO_PROXYcovers hosts and their subdomains, and localhost, IPv4 loopback, and IPv6 loopback always remain direct so local preview and composition servers stay reachable. URLs containing proxy credentials fail with a clear error before Chrome starts.The CLI launch owner, engine capture pool, GPU probes, and audio browser launches share this policy. Resolved flags are part of the pool fingerprint, so changing the proxy cannot reuse a browser with an older policy. There is no new CLI flag, configuration field, or composition format.
Validation: mapping and refusal tests, a regression that fails on main when a changed proxy reuses the old browser, and real Chrome tests through both launch owners. A local stub receives an external HTTP fetch and denies its HTTPS CONNECT, while the local composition page bypasses the proxy. Deliberate mutations verify the mapping tests detect broken precedence, scheme selection, credentials refusal, bypass rules, and unset-variable behavior. Targeted typechecks and pre-commit checks pass.