Skip to content

Add cabal package for version 0.3.16 - #1

Merged
hsyl20 merged 1 commit into
haskell-cryptography:v0.3.16-cabalfrom
hsyl20:v0.3.16-cabal-next
Jan 6, 2026
Merged

Add cabal package for version 0.3.16#1
hsyl20 merged 1 commit into
haskell-cryptography:v0.3.16-cabalfrom
hsyl20:v0.3.16-cabal-next

Conversation

@hsyl20

@hsyl20 hsyl20 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@hsyl20
hsyl20 marked this pull request as draft January 6, 2026 15:04
@hsyl20
hsyl20 marked this pull request as ready for review January 6, 2026 15:04
@hsyl20 hsyl20 changed the title V0.3.16 cabal next Add cabal package for version 0.3.16 Jan 6, 2026
@hsyl20
hsyl20 force-pushed the v0.3.16-cabal-next branch from 0d8df85 to 4dfc77d Compare January 6, 2026 15:16
@hsyl20
hsyl20 requested a review from Kleidukos January 6, 2026 15:19

@Kleidukos Kleidukos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@hsyl20

hsyl20 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator Author

@Kleidukos Would you like to review this first package? I've added CI in the process of migrating it from my proof-of-concept branch. Note that we build the sdist and not directly do cabal test because otherwise cabal picks files that aren't mentioned in extra-source-files...

@hsyl20

hsyl20 commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator Author

You're faster to review than I am to type comments :D

@hsyl20
hsyl20 merged commit 0fd1d38 into haskell-cryptography:v0.3.16-cabal Jan 6, 2026
5 checks passed
@Kleidukos

Copy link
Copy Markdown
Member

Héhé. I see that it's a GH fork of the original sources. Is there a written procedure to follow in order to update the bundled bindings? Or do you diff the files and add them manually to the cabal file?

@hsyl20

hsyl20 commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator Author

I see that it's a GH fork of the original sources. Is there a written procedure to follow in order to update the bundled bindings? Or do you diff the files and add them manually to the cabal file?

No written procedure. I've never updated the bindings yet but I think we would just rebase and test on CI. The build system is pretty dumb because it only builds two files (.c and .S) which include many other files. If they add some files, we only have to add them to cabal's extra-source-files otherwise building the contents of the sdist fails (that why we test this on CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants