fix: parseYAMLBoolean for boolean flags + bump ghcup to 0.2.6.2 - #147
Closed
clearnature wants to merge 4 commits into
Closed
fix: parseYAMLBoolean for boolean flags + bump ghcup to 0.2.6.2#147clearnature wants to merge 4 commits into
clearnature wants to merge 4 commits into
Conversation
added 2 commits
July 10, 2026 20:39
…c/disable-matcher These four boolean flags used (inputs[key] || '') !== '' pattern which treats YAML 'false' string as true. Replace with parseYAMLBoolean which correctly handles YAML boolean semantics. Bug: enable-stack: false was treated as true → ghcup tries to install stack → GHCup-00130 on version resolution failure. Fixes agda/agda#8619
v0.1.50.2 is too old and cannot install stack 3.9.3 (GHCup-00130). v0.2.6.2 is the latest stable and confirmed working with stack 3.9.3.
Author
This was referenced Jul 12, 2026
Contributor
|
hi @andreasabel, I'm in need of using the latest GHCup. Is there anything I can do to help you. :) |
Member
|
Thanks @clearnature , back from vacation, I released this as v2.12.0. |
Member
|
@Kleidukos I invited you as maintainer, so you can help yourself next time. I am happy to get help on this repo, since I am not really proficient in TypeScript. |
Contributor
|
@andreasabel got it, thanks for the invitation. :) |
Member
|
This PR has been merged by cherry-picking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Use parseYAMLBoolean for boolean flags (opts.ts)
The four boolean flags (enable-stack, stack-no-global, stack-setup-ghc, disable-matcher) used
(inputs[key] || '') !== ''which treats YAML string 'false' as true.This means
enable-stack: falsewas interpreted astrue, causing the action to try installing stack even when explicitly disabled → GHCup-00130 on ghcup version resolution failure.Fix: use the existing
parseYAMLBooleanfunction (already used for cabal-update).2. Bump bundled ghcup from 0.1.50.2 to 0.2.6.2
ghcup 0.1.50.2 cannot download stack 3.9.3 (the current latest). ghcup 0.2.6.2 is the latest stable release and confirmed working with stack 3.9.3.
Verification
🤖 Generated with Qwen Code (69-shotted by Qwen-Coder)