docs: fix two 404 links in README - #3137
Open
rajanpanth wants to merge 2 commits into
Open
Conversation
joi.dev has no index page at /api/ or /policies/. The API reference is served at /api/18.x.x and the policies section starts at /policies/coc, which is also where joi.dev's own navigation points.
Collaborator
|
/api/ is redirecting, only the policies part is valid |
joi.dev/api/ resolves client-side to /api/18.x.x in a browser, so it is not broken. Only the /policies/ link is a genuine 404.
Author
|
You're right, thanks. I checked with curl, which gets a hard 404 with no
Pushed a commit restoring the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the four "Useful resources" links in the README return 404:
https://joi.dev/api/https://joi.dev/api/18.x.xhttps://joi.dev/policies/https://joi.dev/policies/cocjoi.dev serves no index page at either
/api/or/policies/. The API reference lives under a version segment, and the policies section has no landing page — its first entry is the Code of Conduct, which is also where joi.dev's own homepage navigation points.The other two resource links (
/resources/status/#joiand/resources/changelog/) resolve fine and are untouched.Separately, and outside the scope of this PR: joi.dev's own top navigation links to
/api, which 404s for the same reason — worth fixing on the site side.