Repository navigation
Conversation
A laser-weld corner closes the mitre seam tight, as Tear does, and cuts a round hole the size of corner_relief where the bends cross, centred at the seam root, so the corner does not tear as it bends and the seam can be welded. On the surfaces-first develop every corner rip is already a mitre with a gap, so tangency-labs#12651's V tabs at the mitre ends would come out as Tear. The hole at the root is what a weld corner adds. - vendored solidcore: CornerRelief::Weld in solidcore-record, solidcore develop::sheet and the solidcore-convert mappings; layout's weld_cut places the hole. - doc: ReliefShape::LaserWeld ("laser_weld"); settle falls back to Tear below MIN_RELIEF and to a notch with a note when the flanges are not closed toward each other. - schema, command help, dialog labels, locales, book and skill docs. - test: the hole centres, its area bounds and the volume identity against Tear on the 90 degree tray, kept through unfold/refold. Idea and original PR by admin.greg (tangency-labs#12651).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of tangency-labs#12651 (laser-weld corner relief, by admin.greg / @ocpistol-bec) onto the surfaces-first develop in tangency-labs#9245.
What it does
laser_weld("Laser weld" in the dialogs).corner_reliefwhere the bends cross. The hole is centred at the seam root, where the bends' tangent lines meet on the shared panel. The corner can't tear as it bends, and the seam is left ready to weld.How it differs from tangency-labs#12651's original V tabs
On tangency-labs#9245 every corner rip is already
Lap::Miter { gap }. Mitre-cut tabs at the seam ends would therefore come out identical to Tear. What a weld corner adds is the hole at the root, which stops tearing. So this port is Tear's closed mitre seam plus a corner-relief-sized round hole. This matches the line for laser weld in your table: "the one to add, on the same corner code".Enum touch across the three vendored crates
CornerRelief::Weldis added in:solidcore/crates/solidcore-record/src/develop.rs(the record enum)solidcore/crates/solidcore/src/develop/sheet.rs(the kernel enum)solidcore/crates/solidcore-convert/src/develop.rs(the mappings both ways)develop/layout.rsgainsweld_cut:corner_cutreturns it forWeld. The hole is centred at the crossing of the zones' shared-panel-side edges. Its two arcs meet inside the wedge between the zone ends.Also touched
schema pattern, shape-list error strings,
manage_ruleshelp, dialog labels, pending locale strings (en, ar, de, he, ja, ko, vi, zh), book guide, skill reference, face names (Weld walls are named like Tear's).Tests (buildq)
a_laser_weld_corner_closes_the_seam_and_holes_its_root: 1 passed. On the 90° alu tray withcorner_relief1 mm, it checks:schema::sheet: 18 passedcorner_relief: 1 passedCredit: admin.greg (@ocpistol-bec) for the laser-weld relief and the original PR.